It's good for a start but I have some suggestions:
1. You've got the positions right but it needs to be faster. Humans don't normally walk that slow. I'll address how fast below.
2. It's a bit mechanical. It's just at a constant speed and there's no weight to the walk. He's just kinda floating.
Also, there needs to be a bobbing up and down movement because he is lifting himself up with his legs and then falling back to earth.
3. As he goes up he needs to go slower because he is lifting himself of the ground and when he goes down he needs to go faster because he is dropping to the ground.
The speeds I usually have it at are 8 frames going up and 6 coming down.
I hope this helps!
Don't be discouraged! Walks are one of the hardest things to get right. You should see some of my earliest cycles. They were horrible! But as I practiced I got better.
I'm thinking of putting together a walk cycle tutorial. I think that would be helpful to people.
James
